put the warning explaining the validation error in front of the

2001-11-28  Havoc Pennington  <hp@redhat.com>

	* gtk/gtktextview.c (gtk_text_view_paint): put the warning
	explaining the validation error in front of the G_BREAKPOINT

	* gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
	process updates with include_children = FALSE instead of TRUE, so
	we redraw the range only, not the whole darn window.  Making
	GtkRange a NO_WINDOW widget had weirdly caused the text widget
	Trace/breakpoint trap bug to become much easier to trigger.

diff --git a/ChangeLog b/ChangeLog
index 3e7d52b1ccc01c69e0dbc65b303972d1c74e042a..d78968dc691e5e93a76bde8e99d6af63742fde66 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2001-11-28  Havoc Pennington  <hp@redhat.com>
+
+       * gtk/gtktextview.c (gtk_text_view_paint): put the warning
+       explaining the validation error in front of the G_BREAKPOINT
+
+       * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
+       process updates with include_children = FALSE instead of TRUE, so
+       we redraw the range only, not the whole darn window.  Making
+       GtkRange a NO_WINDOW widget had weirdly caused the text widget
+       Trace/breakpoint trap bug to become much easier to trigger.
+
 Wed Nov 28 14:12:03 2001  Owen Taylor  <otaylor@redhat.com>
 
        * gdk/Makefile.am (gdk_public_h_sources): Remove reference

diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0
index 3e7d52b1ccc01c69e0dbc65b303972d1c74e042a..d78968dc691e5e93a76bde8e99d6af63742fde66 100644 (file)
--- a/ChangeLog.pre-2-0
+++ b/ChangeLog.pre-2-0
@@ -1,3 +1,14 @@
+2001-11-28  Havoc Pennington  <hp@redhat.com>
+
+       * gtk/gtktextview.c (gtk_text_view_paint): put the warning
+       explaining the validation error in front of the G_BREAKPOINT
+
+       * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
+       process updates with include_children = FALSE instead of TRUE, so
+       we redraw the range only, not the whole darn window.  Making
+       GtkRange a NO_WINDOW widget had weirdly caused the text widget
+       Trace/breakpoint trap bug to become much easier to trigger.
+
 Wed Nov 28 14:12:03 2001  Owen Taylor  <otaylor@redhat.com>
 
        * gdk/Makefile.am (gdk_public_h_sources): Remove reference

diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10
index 3e7d52b1ccc01c69e0dbc65b303972d1c74e042a..d78968dc691e5e93a76bde8e99d6af63742fde66 100644 (file)
--- a/ChangeLog.pre-2-10
+++ b/ChangeLog.pre-2-10
@@ -1,3 +1,14 @@
+2001-11-28  Havoc Pennington  <hp@redhat.com>
+
+       * gtk/gtktextview.c (gtk_text_view_paint): put the warning
+       explaining the validation error in front of the G_BREAKPOINT
+
+       * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
+       process updates with include_children = FALSE instead of TRUE, so
+       we redraw the range only, not the whole darn window.  Making
+       GtkRange a NO_WINDOW widget had weirdly caused the text widget
+       Trace/breakpoint trap bug to become much easier to trigger.
+
 Wed Nov 28 14:12:03 2001  Owen Taylor  <otaylor@redhat.com>
 
        * gdk/Makefile.am (gdk_public_h_sources): Remove reference

diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2
index 3e7d52b1ccc01c69e0dbc65b303972d1c74e042a..d78968dc691e5e93a76bde8e99d6af63742fde66 100644 (file)
--- a/ChangeLog.pre-2-2
+++ b/ChangeLog.pre-2-2
@@ -1,3 +1,14 @@
+2001-11-28  Havoc Pennington  <hp@redhat.com>
+
+       * gtk/gtktextview.c (gtk_text_view_paint): put the warning
+       explaining the validation error in front of the G_BREAKPOINT
+
+       * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
+       process updates with include_children = FALSE instead of TRUE, so
+       we redraw the range only, not the whole darn window.  Making
+       GtkRange a NO_WINDOW widget had weirdly caused the text widget
+       Trace/breakpoint trap bug to become much easier to trigger.
+
 Wed Nov 28 14:12:03 2001  Owen Taylor  <otaylor@redhat.com>
 
        * gdk/Makefile.am (gdk_public_h_sources): Remove reference

diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4
index 3e7d52b1ccc01c69e0dbc65b303972d1c74e042a..d78968dc691e5e93a76bde8e99d6af63742fde66 100644 (file)
--- a/ChangeLog.pre-2-4
+++ b/ChangeLog.pre-2-4
@@ -1,3 +1,14 @@
+2001-11-28  Havoc Pennington  <hp@redhat.com>
+
+       * gtk/gtktextview.c (gtk_text_view_paint): put the warning
+       explaining the validation error in front of the G_BREAKPOINT
+
+       * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
+       process updates with include_children = FALSE instead of TRUE, so
+       we redraw the range only, not the whole darn window.  Making
+       GtkRange a NO_WINDOW widget had weirdly caused the text widget
+       Trace/breakpoint trap bug to become much easier to trigger.
+
 Wed Nov 28 14:12:03 2001  Owen Taylor  <otaylor@redhat.com>
 
        * gdk/Makefile.am (gdk_public_h_sources): Remove reference

diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6
index 3e7d52b1ccc01c69e0dbc65b303972d1c74e042a..d78968dc691e5e93a76bde8e99d6af63742fde66 100644 (file)
--- a/ChangeLog.pre-2-6
+++ b/ChangeLog.pre-2-6
@@ -1,3 +1,14 @@
+2001-11-28  Havoc Pennington  <hp@redhat.com>
+
+       * gtk/gtktextview.c (gtk_text_view_paint): put the warning
+       explaining the validation error in front of the G_BREAKPOINT
+
+       * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
+       process updates with include_children = FALSE instead of TRUE, so
+       we redraw the range only, not the whole darn window.  Making
+       GtkRange a NO_WINDOW widget had weirdly caused the text widget
+       Trace/breakpoint trap bug to become much easier to trigger.
+
 Wed Nov 28 14:12:03 2001  Owen Taylor  <otaylor@redhat.com>
 
        * gdk/Makefile.am (gdk_public_h_sources): Remove reference

diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8
index 3e7d52b1ccc01c69e0dbc65b303972d1c74e042a..d78968dc691e5e93a76bde8e99d6af63742fde66 100644 (file)
--- a/ChangeLog.pre-2-8
+++ b/ChangeLog.pre-2-8
@@ -1,3 +1,14 @@
+2001-11-28  Havoc Pennington  <hp@redhat.com>
+
+       * gtk/gtktextview.c (gtk_text_view_paint): put the warning
+       explaining the validation error in front of the G_BREAKPOINT
+
+       * gtk/gtkrange.c (gtk_range_adjustment_value_changed): call
+       process updates with include_children = FALSE instead of TRUE, so
+       we redraw the range only, not the whole darn window.  Making
+       GtkRange a NO_WINDOW widget had weirdly caused the text widget
+       Trace/breakpoint trap bug to become much easier to trigger.
+
 Wed Nov 28 14:12:03 2001  Owen Taylor  <otaylor@redhat.com>
 
        * gdk/Makefile.am (gdk_public_h_sources): Remove reference

diff --git a/gtk/gtkrange.c b/gtk/gtkrange.c
index 06a261a0768b28007d1f7aaa919670894fdfc78e..d2ead16d1ff60fec529e5be1176fe996b6922cbd 100644 (file)
--- a/gtk/gtkrange.c
+++ b/gtk/gtkrange.c
@@ -1446,7 +1446,7 @@ gtk_range_adjustment_value_changed (GtkAdjustment *adjustment,
   gtk_widget_queue_draw (GTK_WIDGET (range));
   /* This is so we don't lag the widget being scrolled. */
   if (GTK_WIDGET_REALIZED (range))
-    gdk_window_process_updates (GTK_WIDGET (range)->window, TRUE);
+    gdk_window_process_updates (GTK_WIDGET (range)->window, FALSE);
   
   /* Note that we don't round off to range->round_digits here.
    * that's because it's really broken to change a value

diff --git a/gtk/gtktextview.c b/gtk/gtktextview.c
index ae03661bef556aebc5e5f0ee86c0f4fa8e271155..f5595ecee12acf76a0ba24e7771db7fbb784559b 100644 (file)
--- a/gtk/gtktextview.c
+++ b/gtk/gtktextview.c
@@ -3719,8 +3719,8 @@ gtk_text_view_paint (GtkWidget      *widget,
   
   if (!text_view->onscreen_validated)
     {
+      g_warning (G_STRLOC ": somehow some text lines were modified or scrolling occurred since the last validation of lines on the screen - this is a known bug, no need to report.");
       G_BREAKPOINT ();
-      g_warning (G_STRLOC ": somehow some text lines were modified or scrolling occurred since the last validation of lines on the screen");
     }
   
 #if 0